-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline VQA: Add support for list of images and questions as pipeline input #31217
Pipeline VQA: Add support for list of images and questions as pipeline input #31217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this capability!
Seems like something which would be useful to have. Alongside the logic, there's a few things we should add alongside:
- Update docstrings to reflect the new input types
- Add tests for the new input types
Hi @amyeroberts, thank you for reviewing :) I added the tests and docstrings |
Found and fixed the problem with the dataset :) Now dataset (in form of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks for adding this!
Thanks again for this contribution! |
What does this PR do?
Fixes #31216
This PR will allow passing list of either
PIL.Image
orstr
as pipeline argument (andlist[str]
for questions). Passing dataset (in form of.pt_utils.KeyDataset
) is also allowed.So this code will now work (passing the dataset as list)
This also works:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.