Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading special_tokens_map_file #31012

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ZhiyuanChen
Copy link
Contributor

What does this PR do?

If special tokens map have special specified, e.g.:

SPECIAL_TOKENS_MAP = {
    "pad_token": {
        "content": "<pad>",
        "lstrip": False,
        "normalized": False,
        "rstrip": False,
        "single_word": False,
        "special": True,
    },
}

loading pretrained with special tokens map would complain:

TypeError: tokenizers.AddedToken() got multiple values for keyword argument 'special'

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@ArthurZucker
Copy link
Collaborator

Hey! Which version of transformers are you using? Also which tokenizer are you trying to load?
Special map is depracted and only kept for BC

@ZhiyuanChen
Copy link
Contributor Author

Hey! Which version of transformers are you using? Also which tokenizer are you trying to load? Special map is depracted and only kept for BC

Hi~
I'm using 4.39.3 to load an external tokenizer.
I believe numerous codebase are still keeping the special tokens map like https://huggingface.co/facebook/esm2_t6_8M_UR50D/blob/main/special_tokens_map.json.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Could you just rebase on main ?

@ZhiyuanChen
Copy link
Contributor Author

Okay! Could you just rebase on main ?

One moment

@ArthurZucker ArthurZucker merged commit f5c0fa9 into huggingface:main Jun 6, 2024
21 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ZhiyuanChen ZhiyuanChen deleted the patch-2 branch June 6, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants