Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resume_download future warning #31007

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented May 24, 2024

Fix #31002 and follow-up #30618.

Looks like I forgot a resume_download in #30618. This PR fixes it to avoid a FutureWarning for which the user can't do much.

cc @albertvillanova

Note: this is "simply" as warning but should not trigger any errors. It triggers one in datasets' CI but that's only because of pytest settings.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a small test ? like we snapshot download some .bin to a tempdir, set flag or use local file only

@Wauplin
Copy link
Contributor Author

Wauplin commented May 24, 2024

@ArthurZucker I added a regression test in 6921a7f. It is not related to local_files_only or snapshot_download problems, just a FutureWarning raised when resume_download is passed to latest version of huggingface_hub.

@Wauplin
Copy link
Contributor Author

Wauplin commented May 24, 2024

(feel free to merge whenever it's approved/CI is happy)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit fd3c128 into main May 24, 2024
18 of 21 checks passed
@ArthurZucker ArthurZucker deleted the 31002-fix-future-warning branch May 24, 2024 12:35
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError due to huggingface-hub FutureWarning about resume_download
4 participants