Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantization / TST: Fix remaining quantization tests #31000

Merged
merged 3 commits into from
May 24, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented May 24, 2024

What does this PR do?

This PR fixes the remaining quantization tests( quanto quantized cache) + makes sure the GGUF tests are run (they all pass on the T4 VM) by removing it from the transformers-all-latest-gpu docker image to the quantization docker image

========================================================================================================= 11 passed, 3 warnings in 506.17s (0:08:26) ==========================================================================================================

cc @SunMarc @ydshieh @zucchini-nlp

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, for quanto it's hardware differences I guess 🥲
Thanks for fixing!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. BTW, what's the role of gguf here?

I mean shouldn't we have some extra require_xxx for class QuantoKVCacheQuantizationTest(unittest.TestCase): ?

@younesbelkada
Copy link
Contributor Author

For GGUF it is just that the tests were currently compltely skipped, these tests are independent from the quanto cache tests !

@ydshieh
Copy link
Collaborator

ydshieh commented May 24, 2024

OK. But my question is still there: we don't need any require_xxx for QuantoKVCacheQuantizationTest? It looks like it requires some quantize libraries being installed, no?

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! +1 for @ydshieh comments. Let's add a @require_quanto for the kv-cache quantization tests

@younesbelkada younesbelkada merged commit 658b849 into main May 24, 2024
19 checks passed
@younesbelkada younesbelkada deleted the fix-quant-tests-final branch May 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants