-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perceiver interpolate position embedding #30979
Merged
amyeroberts
merged 8 commits into
huggingface:main
from
g1y5x3:perceiver_inter_pos_embed
May 24, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
53bdc07
add test that currently fails
g1y5x3 9401149
test passed
g1y5x3 eb3bcdf
all perceiver passed
g1y5x3 4f16e8b
fixup, style, quality, repo-consistency, all passed
g1y5x3 f33bdb3
Apply suggestions from code review: default to False + compute sqrt o…
g1y5x3 fdb4e5f
fix a minor bracket
g1y5x3 43bc637
replace dim with self._num_channels
g1y5x3 2891e0d
add arguments to the rest preprocessors
g1y5x3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amyeroberts since
self.input_processor
here could also be eitherTextPreprocessor
orMultimodalPreprosessor
, it would complaingot unexpected keyword argument
if it was not added to theforward()
of those two corresponding methods. Alternatively, maybe we could add another condition here to callself.input_processor
with just two arguments unless it isImagePreprocessor
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's OK, I just wanted to make sure that this was deliberate