Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in Pipeline documentation #30948

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

junhl
Copy link
Contributor

@junhl junhl commented May 22, 2024

What does this PR do?

Fix link in few following Pipeline documentations, as originally reported by #28224

Fixes #28224
Consulted comments in previous PR attempts in #28231 and #30562

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Documentation: @stevhliu and @MKhalusova

@junhl
Copy link
Contributor Author

junhl commented May 22, 2024

Currently checks seem to be failing from original main, not from changes in this PR. Will rebase once main is fixed.

Review can be done @stevhliu @gante

EDIT: checks are now all green

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! 🤗

@stevhliu stevhliu merged commit d44e1ae into huggingface:main May 22, 2024
8 checks passed
@junhl junhl deleted the fix-issue-28224 branch May 22, 2024 16:52
@junhl junhl mentioned this pull request May 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] - Wrong link to model#generative-models in Pipeline docs
3 participants