Use torch 2.3 for CI
#30837
Merged
Use torch 2.3 for CI
#30837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
May 15, 2024
|
Hi @amyeroberts For CI on GitHub Actions + such changes, we don't really run CI before merge. We are going to use torch 2.3, it's for sure. We will try to fix the failing tests once the reports are sent via CI after merge. The changes on this CI won't affect pull requests' CircleCI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It has been sometime torch 2.3 is released. I should have done this earlier.
In particular, the torch compile related tests require it.
(We might have issue on T4 even with torch 2.3 however)