Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamba - Skip 4d custom attention mask test #30826

Merged
merged 2 commits into from
May 15, 2024

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented May 15, 2024

What does this PR do?

Fixes failing test on main: https://app.circleci.com/pipelines/github/huggingface/transformers/92832/workflows/0cbde306-131c-479b-b938-bca2fb838a82/jobs/1215777

Applies the same fix as #30780

However, applying created another failing test: test_assisted_decoding_matches_greedy_search_0_random.

This fails because the model now has _supports_cache_class unset, but passes past_key_values as HybridMambaAttentionDynamicCache, which triggers an exception here.

Mamba doesn't have this issue, because it doesn't define any models in all_generative_models in its model tester, and so the generation tests "pass" but are in fact skipped.

The tests are skipped now, but we should update either the interaction between the cache and generation to ensure this isn't necessary. I've opened a related issue here #30828

cc @gante

@amyeroberts amyeroberts requested review from ArthurZucker and removed request for ArthurZucker May 15, 2024 12:13
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amyeroberts amyeroberts merged commit 64c06df into huggingface:main May 15, 2024
21 checks passed
@amyeroberts amyeroberts deleted the fix-jamba-cache-class branch May 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants