Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable use_cache if using gradient checkpointing #30320

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

chenzizhao
Copy link
Contributor

What does this PR do?

I disable use_cache when gradient checkpointing is enabled in the new Idefics2 (like in Idefics, Mistral7B, and many others). Previously, the backward pass raises a shape error.

Fixes #30301

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc: @amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix so quickly!

@amyeroberts amyeroberts merged commit 57b92bb into huggingface:main Apr 18, 2024
17 checks passed
@chenzizhao chenzizhao deleted the idefics2_gc branch June 14, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idefics2 raises shape error in the backward pass with gradient_checkpointing
2 participants