Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quality Olmo + SDPA #30302

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix quality Olmo + SDPA #30302

merged 1 commit into from
Apr 17, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Apr 17, 2024

Byproduct of me not merging/rebasing after #29890, conflicting with #30070

@fxmarty fxmarty requested a review from ArthurZucker April 17, 2024 20:55
@ArthurZucker ArthurZucker merged commit ec92f98 into main Apr 17, 2024
18 checks passed
@ArthurZucker ArthurZucker deleted the fix-quality-olmo branch April 17, 2024 21:08
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@fxmarty
Copy link
Contributor Author

fxmarty commented Apr 17, 2024

For the record some olmo slows tests were already failign before this PR (running on A100). Otherwise all good.

FAILED tests/models/olmo/test_modeling_olmo.py::OlmoIntegrationTest::test_model_1b_logits - RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument index ...
FAILED tests/models/olmo/test_modeling_olmo.py::OlmoIntegrationTest::test_model_7b_greedy_generation - RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument index ...
FAILED tests/models/olmo/test_modeling_olmo.py::OlmoIntegrationTest::test_model_7b_logits - RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument index ...
FAILED tests/models/olmo/test_modeling_olmo.py::OlmoIntegrationTest::test_model_7b_twin_2t_logits - RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument index ...

ArthurZucker added a commit that referenced this pull request Apr 18, 2024
ArthurZucker added a commit that referenced this pull request Apr 18, 2024
ArthurZucker added a commit that referenced this pull request Apr 18, 2024
* Revert "Re-enable SDPA's FA2 path (#30070)"

This reverts commit 05bdef1.

* Revert "Fix quality Olmo + SDPA (#30302)"

This reverts commit ec92f98.
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
* Revert "Re-enable SDPA's FA2 path (#30070)"

This reverts commit 05bdef1.

* Revert "Fix quality Olmo + SDPA (#30302)"

This reverts commit ec92f98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants