Workflow: Update tailscale to release version #30268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glegendre01
approved these changes
Apr 16, 2024
ydshieh
approved these changes
Apr 16, 2024
|
No question about this PR itself. But I have a related question: why if we want to ssh to the runner even before the pytest is running? Isn't it better to put the ssh job at the beginning (if we are in debugger mode)? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
good point @ydshieh
not sure this is possible, @glegendre01 might know best here 🙏 |
ydshieh
pushed a commit
that referenced
this pull request
Apr 23, 2024
Update tailscale to release version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For the new push important models workflow, we were using a dev version of the tailscale GHA, now that a proper v1 has been released, we should switch to it - as discussed offline with @glegendre01
cc @glegendre01 @ydshieh @amyeroberts