Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replaced deprecated logger.warn with logger.warning #30197

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

What does this PR do?

logging.warn and logging.Logger.warn are deprecated in favor of logging.warning and logging.Logger.warning, which are functionally equivalent. (https://docs.python.org/3/library/logging.html#logging.warning)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts @ArthurZucker

@Sai-Suraj-27 Sai-Suraj-27 changed the title fix: Fixed deprecated logger.warn with logger.warning fix: Replaced deprecated logger.warn with logger.warning Apr 11, 2024
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit caa5c65 into huggingface:main Apr 12, 2024
20 checks passed
@Sai-Suraj-27 Sai-Suraj-27 deleted the fix_logger.warning branch July 10, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants