Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC] Fix BC for other libraries #29934

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[BC] Fix BC for other libraries #29934

merged 2 commits into from
Mar 28, 2024

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Fixes #29783

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker marked this pull request as ready for review March 28, 2024 12:54
@ArthurZucker ArthurZucker changed the title [BC] Fix BC for other models [BC] Fix BC for other libraries Mar 28, 2024
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This works but I wonder if we want a more general fix for something like this in future or maybe design guidelines. If we have a model with many nested layers, we don't want a chain of many getattrs

@ArthurZucker
Copy link
Collaborator Author

For sure. accessing the past_key_values should maybe be done via a getter or rely on generation_config.cache_implementation!

@ArthurZucker ArthurZucker merged commit 2bbbf1b into main Mar 28, 2024
19 checks passed
@ArthurZucker ArthurZucker deleted the fix-bc-cache branch March 28, 2024 14:13
amyeroberts pushed a commit that referenced this pull request Mar 28, 2024
@TechxGenus TechxGenus mentioned this pull request Mar 30, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Catcher' object has no attribute 'self_attn' #29352
3 participants