Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe import of LRScheduler #29919

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Safe import of LRScheduler #29919

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
272fbd4
Safe import of LRScheduler
amyeroberts Mar 27, 2024
93e660f
Update src/transformers/trainer_pt_utils.py
amyeroberts Mar 28, 2024
857f785
Update src/transformers/trainer_pt_utils.py
amyeroberts Mar 28, 2024
5ac63ab
Fix up
amyeroberts Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/transformers/trainer_pt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,18 @@
import torch
import torch.distributed as dist
from torch import nn
from torch.optim.lr_scheduler import LRScheduler
from torch.utils.data import Dataset, IterableDataset, RandomSampler, Sampler
from torch.utils.data.distributed import DistributedSampler

from .integrations.deepspeed import is_deepspeed_zero3_enabled
from .tokenization_utils_base import BatchEncoding
from .utils import is_sagemaker_mp_enabled, is_torch_xla_available, is_training_run_on_sagemaker, logging
from .utils import (
is_sagemaker_mp_enabled,
is_torch_available,
is_torch_xla_available,
is_training_run_on_sagemaker,
logging,
)


if is_training_run_on_sagemaker():
Expand All @@ -49,6 +54,15 @@
if is_torch_xla_available():
import torch_xla.core.xla_model as xm

if is_torch_available():
from .pytorch_utils import is_torch_greater_or_equal_than_2_0

if is_torch_greater_or_equal_than_2_0:
from torch.optim.lr_scheduler import LRScheduler
else:
from torch.optim.lr_scheduler import _LRScheduler as LRScheduler


# this is used to suppress an undesired warning emitted by pytorch versions 1.4.2-1.7.0
try:
from torch.optim.lr_scheduler import SAVE_STATE_WARNING
Expand Down
Loading