Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbrx #29910

Closed
wants to merge 11 commits into from
Closed

dbrx #29910

wants to merge 11 commits into from

Conversation

eitanturok
Copy link
Contributor

@eitanturok eitanturok commented Mar 27, 2024

What does this PR do?

Add dbrx to transformers from https://github.com/databricks/dbrx/tree/main/model.

To run dbrx:

from transformers import DbrxForCausalLM
model = DbrxForCausalLM.from_pretrained(
    "databricks/dbrx-instruct",
    device_map="auto",
    )

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@milocress
Copy link

GH Issue here: #29911

@winglian
Copy link
Contributor

you need to add dbrx to the tokenization_auto.py and configuration_auto.py

"clean_up_tokenization_spaces": false,
"eos_token": "<|endoftext|>",
"model_max_length": 8192,
"tokenizer_class": "GPT4Tokenizer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no GPT4Tokenizer class already in transformers or this PR?

@giyaseddin giyaseddin mentioned this pull request Mar 27, 2024
5 tasks
@eitanturok
Copy link
Contributor Author

Closing this PR because it is being complete here #29921

@eitanturok eitanturok closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants