Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LlavaNext] Fix llava next unsafe imports #29773

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Fixes the imports of LlavaNext and the auto-mapping. this was pushed to the release

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

In general, functions like select_best_resolution shouldn't go in image_processing_utils.py as it's model specific. The reason is to try and avoid the situation we had with some of the feature extractors functionality:

  • Sometimes the same/similar function was implemented more than once, creating ambiguity over which one was "right"
  • Or a single function tries to cover too many use cases making it buggy
    I'll think about how we can safely do this in the future.

However, is it's a fairly "general" utility here, so happy with this update :)

@ArthurZucker ArthurZucker merged commit 73a73b4 into main Mar 21, 2024
21 checks passed
@ArthurZucker ArthurZucker deleted the update-llava-imports branch March 21, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants