-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 'decord' with 'av' in VideoClassificationPipeline #29747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for adding this and making our pipelines more accessible 🔥
To resolve the failing quality checks:
- Some are unrelated to this PR. A fix was pushed on main, could you rebase to include this?
- Some are just linting checks - running
make fixup
and pushing the changes should resolve
Thanks for your review!I will fix the remaining problems. |
Rebase the main branch with updates
@amyeroberts sorry for waiting so long! I haved fix all the problems, could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
As the feature request shows, the dependency 'decord' can only be used in x86 instead of aarch. For those users who want to use VideoClassificationPipeline on aarch, we decide to replace 'decord' with 'av' which is a perfect adaptation for the two above-mention architecture.
Fixes # (issue)
feature request
Before submitting
Who can review?
@amyeroberts
Test on V100
To make sure the codes is correct, I test the VideoClassificationPipeline via tests/pipelines/test_pipelines_video_classification.py on V100
Here is my command(the current dir is the root dir of transformers):
The codes of spec.py:
And the version of 'av' is 11.0.0 which is the default version of 'pip install av'
Finaly we can get the 'pass' via testing tests/pipelines/test_pipelines_video_classification.py:
