[tests] extend NOT_DEVICE_TESTS
#29669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a guy working on XPU, I found PR #29213 extremely useful, but I discovered more test cases that will not be tested on accelerators.
The only concern I have is the
repository-skip, e.g. currently I find all files underrepo_utils,toolsandutilsrepositories belong toNOT_DEVICE_TESTS, because these test files don't have the keywordtorch_deviceorgpu. But this doesn't guarantee that people will add DEVICE-relevant tests to these repositories in the future. What are your thoughts on this?@amyeroberts @fxmarty @ydshieh