-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with logit processor during beam search in Flax #29636
fix issue with logit processor during beam search in Flax #29636
Conversation
Hi @giganttheo 👋 Thank you for opening the PR! The fix looks reasonable to me. However, if the fix is indeed correct, I wonder how our code could be running correctly before 🤔 I have three small requests:
|
I think that not many people have encountered this issue before, since most flax logits processors do not really use the About your requests:
without the change, it gives:
For instance the 2-gram with the change, it prompts:
there is no 2-gram repetition For reference, with torch and 2-gram blocking, the model output is:
Show
Show
Show
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giganttheo thank you for the detailed explanations 💛
The same 6 slow tests are failing on main
, so they are not a result of this PR (cc @sanchit-gandhi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
What does this PR do?
Fixes #29635