Generate: left-padding test, revisited #29515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zucchini-nlp -- this is a good example of us adding ugly flakiness-related loops because we didn't understand the cause for flakiness. Now that we understand that left-padding == not exactly the same results, we can write a clean test. |
gante
commented
Mar 7, 2024
| next_logits_wo_padding = model(**model_kwargs).logits[:, -1, :] | ||
|
|
||
| # With left-padding (length 32) | ||
| pad_size = (input_ids.shape[0], 32) |
There was a problem hiding this comment.
Note that the test is now much harder (padding size went from 1 to 32)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 8, 2024
| next_logits_wo_padding = model(**model_kwargs).logits[:, -1, :] | ||
|
|
||
| # With left-padding (length 32) | ||
| pad_size = (input_ids.shape[0], 32) |
| next_logits_with_padding = model(**model_kwargs).logits[:, -1, :] | ||
|
|
||
| # They should result in very similar logits | ||
| self.assertTrue(torch.allclose(next_logits_wo_padding, next_logits_with_padding, atol=1e-5)) |
There was a problem hiding this comment.
surprised that this is enough to make it pass!
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now that we understand why left-padding doesn't produce the exact same outputs (see comment), this PR revisits the left-padding test.
In a nutshell: