Mark test_eager_matches_sdpa_generate flaky for some models
#29479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Mar 7, 2024
|
Apart from qwen2 (that is bugged and I did not work on), other tests are simply flacky. In my experience (for inference) this had no impact on e.g. generation. see pytorch/pytorch#103462 for numerical differences (although for gradients there) |
ArthurZucker
approved these changes
Mar 25, 2024
|
I will remove the one for |
|
For qwen2 I think we should find which one of eager/sdpa is correct and maybe disable the one that is not until fixed :/ |
I can skip it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cc @fxmarty