[ TokenizationLlama] fix the way we convert tokens to strings to keep leading spaces 🚨 breaking fix
#29453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokenizationLlama] fix the way we convert tokens to strings to not always strip prefix space
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
TokenizationLlama] fix the way we convert tokens to strings to not always strip prefix spaceTokenizationLlama] fix the way we convert tokens to strings to keep leading spaces
TokenizationLlama] fix the way we convert tokens to strings to keep leading spacesTokenizationLlama] fix the way we convert tokens to strings to keep leading spaces 🚨 breaking fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29452. Before the
prefix_spaceadded byadd_dummy_prefix_spacewas eaten by thedecodefunction. This is silent, not expected and thus should not be there.input_ids = tokenizer.encode("hello", add_special_tokens=True)would produce["<s>", "▁hello"]but decoded as"<s>hello"