Fix TrainingArguments regression with torch <2.0.0 for dataloader_prefetch_factor #29447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dataloader_prefetch_factor
was added toTrainingArguments
in #28498 with the default valueNone
, but versions oftorch
<2.0.0 do not acceptNone
and will raise an error ifnum_workers == 0 and prefetch_factor != 2
Fixes https://discuss.huggingface.co/t/prefetch-factor-issue/74367/4
Also remove a superfluous check that duplicates the <2.0.0 check and the >=2.0.0 check.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerz @amyeroberts