Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX [bnb] Make unexpected_keys optional #29420

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Fixes: #29193

The code path to:

hf_quantizer.create_quantized_param(model, param, key, "cpu", state_dict)
is accessed only when users use FSDP. The fix is to simply make unexpected_keys optional so that it will not throw the error shown in the issue

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/transformers/quantizers/quantizer_bnb_4bit.py Outdated Show resolved Hide resolved
src/transformers/quantizers/quantizer_bnb_8bit.py Outdated Show resolved Hide resolved
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@younesbelkada younesbelkada merged commit c852d4f into huggingface:main Mar 18, 2024
21 checks passed
@younesbelkada younesbelkada deleted the fix-bnb-fsdp branch March 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants