Idefics: generate fix #29320
Merged
Idefics: generate fix #29320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@gante sorry about that, should have checked for redefinitions |
|
@fxmarty no worries, actually it was our tests' job to catch that 😉 The test fetched failed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ideficsgenerate calls were broken as a result of #29114 (changed interface in_update_model_kwargs_for_generation, whichideficsoverwrite). An example of failing CI, in another PR: https://app.circleci.com/pipelines/github/huggingface/transformers/85633/workflows/d9db77d3-abb4-46cc-948b-9aa9f80b1dfd/jobs/1108730This PR fixes it 🤗
👉 cc @amyeroberts, as you're working on updating the test fetcher. #29114 was an example of failure for the test fetcher. Happy to help on generate test fetching if an extra hand or pointers are needed