Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a hidden bug of GenerationConfig, now the generation_config.json can be loaded successfully #28604

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix a hidden bug of GenerationConfig, now the generation_config.json can be loaded successfully #28604

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
225b210
fix a hidden bug of GenerationConfig
ParadoxZW Jan 19, 2024
1c6c1b3
keep `sort_keys=True` to maintain visibility
ParadoxZW Jan 19, 2024
80b7174
Update src/transformers/generation/configuration_utils.py
ParadoxZW Jan 23, 2024
cc8d414
Update configuration_utils.py
ParadoxZW Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/transformers/generation/configuration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,16 @@ def to_json_string(self, use_diff: bool = True, ignore_metadata: bool = False) -
for metadata_field in METADATA_FIELDS:
config_dict.pop(metadata_field, None)

def convert_keys_to_string(obj):
if isinstance(obj, dict):
return {str(key): convert_keys_to_string(value) for key, value in obj.items()}
elif isinstance(obj, list):
return [convert_keys_to_string(item) for item in obj]
else:
return obj

config_dict = convert_keys_to_string(config_dict)

return json.dumps(config_dict, indent=2, sort_keys=True) + "\n"

def to_json_file(self, json_file_path: Union[str, os.PathLike], use_diff: bool = True):
Expand Down
Loading