-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dataloader prefetch factor in training args and trainer #28498
Merged
amyeroberts
merged 14 commits into
huggingface:main
from
qmeeus:add-dataloader-prefetch-factor
Jan 23, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d0c5647
add dataloader prefetch factor in training args and trainer
qmeeus 3aab38d
remove trailing spaces
qmeeus cd661d8
Merge branch 'huggingface:main' into add-dataloader-prefetch-factor
qmeeus 822cd62
prevent dataloader_num_workers == 0 and dataloader_prefetch_factor !=…
qmeeus 57fbbab
Remove whitespaces in empty line
qmeeus be31d22
Merge branch 'huggingface:main' into add-dataloader-prefetch-factor
qmeeus d19cbb5
Merge branch 'huggingface:main' into add-dataloader-prefetch-factor
qmeeus 1251061
Merge branch 'huggingface:main' into add-dataloader-prefetch-factor
qmeeus af645d0
Update src/transformers/training_args.py
qmeeus c9ee52d
Update src/transformers/training_args.py
qmeeus f7011e2
Update src/transformers/training_args.py
qmeeus 1288b43
Update src/transformers/training_args.py
qmeeus 78d8e4d
Merge branch 'huggingface:main' into add-dataloader-prefetch-factor
qmeeus 23f5979
Merge branch 'main' into add-dataloader-prefetch-factor
qmeeus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this @qmeeus. I was dealing with similar IterableDataset distributed loading issues recently as well :)
one quick question, is it supposed to add
prefectch_factor
configuration outside of this if branch, as this branch is for map-like dataset instead?