Fix trainer saving safetensors: metadata is None #28219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes hiyouga/LLaMA-Factory#1959
If we use
Trainer
to train a model that does not belong to thePreTrainedModel
class, such as thePreTrainedModelwithValuehead
from the TRL library, the trainer will not save the metadata. This leads to errors in reading the metadata when usingAutoModelforCausalLM.from_pretrained
to load the model.transformers/src/transformers/trainer.py
Line 2911 in 29e7a1e
transformers/src/transformers/modeling_utils.py
Lines 3403 to 3407 in 29e7a1e
Although it may sound strange to load a model that does not belong to the
PreTrainedModel
class usingAutoModelForCausalLM.from_pretrained
, this approach benefits model loading by utilizing features such as low_cpu_mem_usage if the model checkpoints share the same structure.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr @pacman100