Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beam score calculation issue for JAX version #27816

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix beam score calculation issue for JAX version #27816

merged 2 commits into from
Dec 7, 2023

Conversation

VsonicV
Copy link
Contributor

@VsonicV VsonicV commented Dec 3, 2023

What does this PR do?

This PR fixes the same beam score calculation issue following #27351 , for JAX version.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@gante

@VsonicV VsonicV force-pushed the beam_score_fix_jax_alone branch from f7d6c84 to d0c9418 Compare December 4, 2023 09:09
@VsonicV VsonicV mentioned this pull request Dec 4, 2023
Merged
5 tasks
gante
gante approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR 🙌

@gante gante requested a review from ArthurZucker December 5, 2023 11:39
ArthurZucker
ArthurZucker approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for propagating the fix

@ArthurZucker ArthurZucker merged commit 7fc8072 into huggingface:main Dec 7, 2023
2 checks passed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@VsonicV VsonicV deleted the beam_score_fix_jax_alone branch December 7, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@gante gante gante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VsonicV @HuggingFaceDocBuilderDev @gante @ArthurZucker