Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example tests from failing #27353

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix example tests from failing #27353

merged 2 commits into from
Nov 8, 2023

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

This PR tweaks the inputs to the accelerate tests to align with the ones in the pytorch tests, which was causing test failures. (Plus some fixes in Accelerate main)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ydshieh @amyeroberts

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 7, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and fixing!

For updating the test, is it necessary to update the number of training steps

examples/pytorch/test_accelerate_examples.py Outdated Show resolved Hide resolved
@muellerzr muellerzr requested a review from amyeroberts November 7, 2023 20:57
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Happy to merge if @ydshieh is happy :)

@ydshieh
Copy link
Collaborator

ydshieh commented Nov 8, 2023

inputs to the accelerate tests to align with the ones in the pytorch tests

Just wondering where the is target of alignment (i.e. the pytorch tests). Otherwise, looks good to me as I trust you that the update makes sense (due to the change in accelerate)!

@muellerzr
Copy link
Contributor Author

@ydshieh for how many steps that example script takes. For the torch ones it’s 10, here it’s 2 :)

@muellerzr muellerzr merged commit efa57cb into main Nov 8, 2023
@muellerzr muellerzr deleted the muellerzr-fix-tests-1 branch November 8, 2023 12:45
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* Fix example tests from failing

* CHange thresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants