make tests of pytorch_example device agnostic #27081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec11770 to
089e3d5
Compare
089e3d5 to
d49020e
Compare
ydshieh
reviewed
Oct 27, 2023
Comment on lines
-96
to
97
| if is_cuda_and_apex_available(): | ||
| if is_torch_fp16_available_on_device(torch_device): | ||
| testargs.append("--fp16") |
There was a problem hiding this comment.
I don't know the reason why we test with fp16 only if apex is available. The change here will means we will test it as long as CI is running on GPU. Not sure if this is what we expect.
@muellerzr Do you happen to know the story here (about the apex part)?
There was a problem hiding this comment.
I think it was a bad copy/paste, because I wouldn't have had that in there on purpose.
There was a problem hiding this comment.
OK thank you for the feedback ❤️
ydshieh
approved these changes
Oct 27, 2023
ydshieh
approved these changes
Oct 27, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
@amyeroberts This is a continuation of (the merged) #25870. There might be more such PRs in the future. |
zhangsibo1129
approved these changes
Oct 28, 2023
amyeroberts
approved these changes
Oct 30, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #25654
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @ydshieh @fxmarty @zhangsibo1129 @arsalanu