Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguous padding_mask and instead use a 2D->4D Attn Mask Mapper #26792

Merged
merged 28 commits into from
Oct 23, 2023
Merged

Remove ambiguous padding_mask and instead use a 2D->4D Attn Mask Mapper #26792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3b5dfb7
[Attn Mask Converter] refactor attn mask
patrickvonplaten Oct 13, 2023
5032628
up
patrickvonplaten Oct 13, 2023
0bfbc1a
Apply suggestions from code review
patrickvonplaten Oct 16, 2023
d173ce3
improve
patrickvonplaten Oct 16, 2023
1d230de
improve
patrickvonplaten Oct 16, 2023
e542a6d
rename
patrickvonplaten Oct 16, 2023
0256cd5
better cache
patrickvonplaten Oct 16, 2023
7e50ec0
renaming
patrickvonplaten Oct 16, 2023
30fc4c3
improve more
patrickvonplaten Oct 16, 2023
2301d6b
improve
patrickvonplaten Oct 16, 2023
4cfb7cb
fix bug
patrickvonplaten Oct 16, 2023
bdb39ae
finalize
patrickvonplaten Oct 16, 2023
67bd54e
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten Oct 19, 2023
2c42f7d
Merge branch 'attn_mask_converter' of https://github.com/huggingface/…
patrickvonplaten Oct 19, 2023
4387ab8
make style & make fix-copies
patrickvonplaten Oct 19, 2023
068ed57
correct more
patrickvonplaten Oct 19, 2023
d18268a
start moving attention_mask
patrickvonplaten Oct 19, 2023
4a99e43
fix llama
patrickvonplaten Oct 19, 2023
2fe66a0
improve falcon
patrickvonplaten Oct 19, 2023
d03d8a1
up
patrickvonplaten Oct 19, 2023
9e553ac
improve more
patrickvonplaten Oct 19, 2023
431b3a8
improve more
patrickvonplaten Oct 19, 2023
f8b2e4e
Update src/transformers/models/owlv2/modeling_owlv2.py
patrickvonplaten Oct 19, 2023
0338ffe
make style
patrickvonplaten Oct 19, 2023
eb95315
Merge branch 'attn_mask_converter' of https://github.com/huggingface/…
patrickvonplaten Oct 19, 2023
ae3eb2e
make style
patrickvonplaten Oct 19, 2023
b438dc8
rename to converter
patrickvonplaten Oct 19, 2023
5339988
Apply suggestions from code review
patrickvonplaten Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/models/deprecated/open_llama/modeling_open_llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def get_input_embeddings(self):
def set_input_embeddings(self, value):
self.embed_tokens = value

# Copied from transformers.models.llama.modeling_llama.LlamaModel._prepare_decoder_attention_mask
# Copied from transformers.models.bart.modeling_bart.BartDecoder._prepare_decoder_attention_mask
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's copy from original source

def _prepare_decoder_attention_mask(self, attention_mask, input_shape, inputs_embeds, past_key_values_length):
# create causal mask
# [bsz, seq_len] -> [bsz, 1, tgt_seq_len, src_seq_len]
Expand Down
Loading