Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doctest] Add configuration_roformer.py #26530

Merged
merged 7 commits into from
Oct 2, 2023
Merged

[Doctest] Add configuration_roformer.py #26530

merged 7 commits into from
Oct 2, 2023

Conversation

hegdeadithyak
Copy link
Contributor

@hegdeadithyak hegdeadithyak commented Oct 2, 2023 •
edited
Loading

Adds configuration_roformer.py to utils/documentation_tests.txt

Based on #19487

@ydshieh Please have a look at this 🌞

@hegdeadithyak hegdeadithyak mentioned this pull request Oct 2, 2023
Closed
@hegdeadithyak
Copy link
Contributor Author

@ydshieh Please have a look at this 🌞

ydshieh
ydshieh reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Adithya4720 . I left a comment :-)

@hegdeadithyak
Copy link
Contributor Author

@ydshieh Please Check this!!

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 2, 2023

Sorry, I forgot to check, but we should remove the entry src/transformers/models/roformer/configuration_roformer.py from the file utils/not_doctested.txt. Otherwise the doctest won't be triggered.

@hegdeadithyak
Copy link
Contributor Author

@ydshieh Sir, Please Check this 😁

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 2, 2023

OK, you corrected it - I was somehow confused by the previous commit! Thanks

@hegdeadithyak
Copy link
Contributor Author

Thankyou

ydshieh
ydshieh approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@ydshieh ydshieh merged commit 4b4c6aa into huggingface:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydshieh ydshieh ydshieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hegdeadithyak @ydshieh @HuggingFaceDocBuilderDev