-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FA2
] Add flash attention for opt
#26414
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
626276f
added flash attention for opt
susnato 7800457
added to list
susnato 689f599
fix use cache (#3)
younesbelkada 74e9687
style fix
susnato cf923e8
fix text
susnato db8cf07
test fix2
susnato af67e0f
reverted until 689f599
susnato edf1610
torch fx tests are working now!
susnato f34b680
small fix
susnato 90be210
Merge branch 'main' into flash_attn_opt
susnato 5cec2ad
added TODO docstring
susnato 2bde7cf
Merge branch 'main' into flash_attn_opt
susnato db18d65
Merge branch 'main' into flash_attn_opt
susnato adfbb69
changes
susnato 10ab9b3
Merge branch 'main' into flash_attn_opt
susnato 7d4c688
comments and .md file modification
susnato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to add a conditional check to check if there is any 0 in the attention mask, sometimes users pass an attention mask with a full ones, therefore we'll need to set
padding_mask
to None to avoid entering the padding case inOPTFlashAttention2
moduleIf the test fails with torch.fx can you try with
torch.isin
? otherwise you can also do a check based on the sum of the attention maskThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sorry for removing it directly without discussing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem at all @susnato ! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails for -
if torch.isin(attention_mask.int(), 0).sum().item()!=0
(AssertionError: Couldn't trace module: symbolically traced variables cannot be used as inputs to control flow)
if torch.isin(attention_mask.int(), 0).sum()!=0
(AssertionError: Couldn't trace module: bool should return bool, returned Tensor)
if attention_mask.sum().item()!=attention_mask.numel()
(AssertionError: Couldn't trace module: symbolically traced variables cannot be used as inputs to control flow)
if not torch.equal(attention_mask, torch.ones_like(attention_mask))
( AssertionError: Couldn't trace module: symbolically traced variables cannot be used as inputs to control flow)