Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code-llama-nit #26300

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Code-llama-nit #26300

merged 4 commits into from
Oct 2, 2023

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Fixes #26156, the fast CodeLLama tokenizer excepts the fill token to be != None.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 20, 2023

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker
Copy link
Collaborator Author

ArthurZucker commented Sep 27, 2023

I'll add a few more update it seems that even when performing infilling the prefix tokens is removed, which should not be done (for both fast and slow): TODO for patch if needed

@ArthurZucker ArthurZucker marked this pull request as ready for review October 2, 2023 15:51
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurZucker ArthurZucker merged commit bab3331 into huggingface:main Oct 2, 2023
@ArthurZucker ArthurZucker deleted the code-llama-nit branch October 2, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of tokens mismatch for CodeLlama-34b-hf
3 participants