-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bros checkpoint #26277
Update bros checkpoint #26277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jinhopark8345 🤗
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Is there a reason why we did not go with creating new repos with |
No reason at all. I also considered that it would be more reliable to use checkpoint that huggingface controls. |
I'll ask for the models to be moved if that is okay with you? |
I am not sure if @jinhopark8345 can move repo to Sorry merged this PR without waiting core maintainers' approval. |
@ArthurZucker I can not move the repo to |
I'll ask for the checkpoints to be move then 😉 |
* fix bros integration test * update bros checkpoint
What does this PR do?
Update Bros checkpoint.
The
naver-clova-ocr/bros-base-uncased
checkpoint hasbbox_projection
layer inBrosEmbeddings
class but this layer is moved toBrosBboxEmbeddings
class. And users are expected to usejinho8345/bros-base-uncased
checkpoint instead ofnaver-clova-ocr/bros-base-uncased
.naver-clova-ocr/bros-base-uncased
: original pretrained checkpoint from naver-clova-ocrjinho8345/bros-base-uncased
: weights renamed version fromnaver-clova-ocr/bros-base-uncased
using conversion scriptBefore submitting
Pull Request section?
to it if that's the case. - Add BROS #23190 (comment)
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ydshieh