[Whisper] Check length of prompt + max new tokens #26164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchit-gandhi
commented
Sep 14, 2023
| @@ -1719,13 +1719,22 @@ def generate( | |||
| decoder_start_token_id, *text_prompt_ids = prompt_ids | |||
| # Slicing the text prompt ids in a manner consistent with the OpenAI implementation | |||
| # to accomodate context space for the prefix (see https://github.com/openai/whisper/blob/c09a7ae299c4c34c5839a76380ae407e7d785914/whisper/decoding.py#L599) | |||
| text_prompt_ids = text_prompt_ids[-self.config.max_length // 2 - 1 :] | |||
There was a problem hiding this comment.
The equivalent variable for the slicing in the OAI implementation is n_ctx: https://github.com/openai/whisper/blob/c09a7ae299c4c34c5839a76380ae407e7d785914/whisper/decoding.py#L599
This corresponds to our max_target_positions:
=> I've corrected this in our implementation. Note that for the pre-trained checkpoints, we set max_length = max_target_positions, so this won't change the behaviour here.
However, it will fix the behaviour for newly initialised checkpoints, where max_length does not match max_target_positions (former defaults to 20, latter defaults to 448).
4 tasks
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Sep 14, 2023
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25422: adds a check for the combined length of prompt + max new tokens. If this total exceeds the model's max length (
max_target_positions), we throw an error.cc @connor-henderson @Helene-Maxcici