Update spectrogram and waveform model mapping for TTS/A pipeline #26114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sanchit-gandhi
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
LGTM, thanks @Vaibhavs10! Are you able to get the correct output when you run the following from the base of the transformers repo?
python utils/update_metadata.py --check-only|
@sanchit-gandhi I just tested, and I essentially get no output! |
|
Requesting final review from Arthur! (who I believe is now on watch 👀) |
ArthurZucker
approved these changes
Sep 13, 2023
ylacombe
approved these changes
Sep 13, 2023
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…gingface#26114) update names mapping for spectrogram and waveform models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the mapping names for the models used for TTS & TTA pipelines.
Fixes # (issue)
MODEL_FOR_TEXT_TO_SPECTROGRAM_NAMES->MODEL_FOR_TEXT_TO_SPECTROGRAM_MAPPING_NAMESMODEL_FOR_TEXT_TO_SPECTROGRAM_NAMES->MODEL_FOR_TEXT_TO_WAVEFORM_MAPPING_NAMESWho can review?
@ylacombe @sanchit-gandhi