Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place AMD GPU tests in a separate workflow #26104

Closed
wants to merge 18 commits into from
Closed

Place AMD GPU tests in a separate workflow #26104

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
48d3efb
Add a Dockerfile for PyTorch + ROCm based on official AMD released ar…
mfuntowicz Sep 6, 2023
c1acac0
Add a new artifact single-amdgpu testing on main
mfuntowicz Sep 6, 2023
70dbee0
Attempt to test the workflow without merging.
mfuntowicz Sep 6, 2023
96639bb
Changed BERT to check if things are triggered
mfuntowicz Sep 6, 2023
8f3e698
Meet the dependencies graph on workflow
mfuntowicz Sep 6, 2023
4cd3871
Revert BERT changes
mfuntowicz Sep 6, 2023
cc62d3d
Add check_runners_amdgpu to correctly mount and check availability
mfuntowicz Sep 7, 2023
a4a639c
Rename setup to setup_gpu for CUDA and add setup_amdgpu for AMD
mfuntowicz Sep 7, 2023
2485383
Fix all the needs.setup -> needs.setup_[gpu|amdgpu] dependencies
mfuntowicz Sep 7, 2023
f99374d
Fix setup dependency graph to use check_runner_amdgpu
mfuntowicz Sep 7, 2023
c045c1e
Let's do the runner status check only on AMDGPU target
mfuntowicz Sep 7, 2023
d3c3e72
Update the Dockerfile.amd to put ourselves in / rather than /var/lib
mfuntowicz Sep 7, 2023
d237227
Restore the whole setup for CUDA too.
mfuntowicz Sep 7, 2023
1a0e302
Let's redisable them
mfuntowicz Sep 7, 2023
ad48aeb
Change BERT to trigger tests
mfuntowicz Sep 7, 2023
0107f55
Restore BERT
mfuntowicz Sep 7, 2023
4a2efa4
Add torchaudio with rocm 5.6 to AMD Dockerfile (#26050)
fxmarty Sep 8, 2023
e87d659
AMDGPU CI lives in an other workflow
fxmarty Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Meet the dependencies graph on workflow
  • Loading branch information
@mfuntowicz
mfuntowicz committed Sep 6, 2023
commit 8f3e698fc722f7c14102af244ecbf4b301f80360
6 changes: 3 additions & 3 deletions .github/workflows/self-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
fetch-depth: 2

- name: Check Runner Status
run: python utils/check_self_hosted_runner.py --target_runners single-gpu-ci-runner-docker,multi-gpu-ci-runner-docker --token ${{ secrets.ACCESS_REPO_INFO_TOKEN }}
run: python utils/check_self_hosted_runner.py --target_runners single-gpu-ci-runner-docker,multi-gpu-ci-runner-docker,single-amdgpu-ci-runner-docker --token ${{ secrets.ACCESS_REPO_INFO_TOKEN }}

check_runners:
name: Check Runners
Expand All @@ -60,8 +60,8 @@ jobs:
needs: check_runners
strategy:
matrix:
machine_type: [single-gpu, multi-gpu]
runs-on: [self-hosted, docker-gpu, '${{ matrix.machine_type }}']
machine_type: [single-gpu, multi-gpu, single-amdgpu]
runs-on: [self-hosted, docker-gpu, docker-amdgpu, '${{ matrix.machine_type }}']
container:
image: huggingface/transformers-all-latest-gpu-push-ci
options: --gpus 0 --shm-size "16gb" --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/
Expand Down