Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change default block_size in block size > max position embeddings #26069

Merged
merged 2 commits into from
Sep 18, 2023
+2 −2
Merged

refactor: change default block_size in block size > max position embeddings #26069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3298a24
refactor: change default block_size when not initialize
pphuc25 Sep 9, 2023
f2fc115
reformat: add the min of block size
pphuc25 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/flax/language-modeling/run_clm_flax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,9 @@ def tokenize_function(examples):
if block_size > config.max_position_embeddings:
logger.warning(
f"The tokenizer picked seems to have a very large `model_max_length` ({tokenizer.model_max_length}). "
"Picking 1024 instead. You can change that default value by passing --block_size xxx."
f"Using block_size={min(1024, config.max_position_embeddings)} instead. You can change that default value by passing --block_size xxx."
)
block_size = 1024
pphuc25 marked this conversation as resolved.
Show resolved Hide resolved
block_size = min(1024, config.max_position_embeddings)
else:
if data_args.block_size > tokenizer.model_max_length:
logger.warning(
Expand Down