Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated llama.md to Korean #26044

Merged
merged 4 commits into from
Sep 8, 2023
Merged

🌐 [i18n-KO] Translated llama.md to Korean #26044

merged 4 commits into from
Sep 8, 2023

Conversation

harheem
Copy link
Contributor

@harheem harheem commented Sep 8, 2023 •
edited
Loading

What does this PR do?

Translated the llama.md file of the documentation to Korean 😄
Thank you in advance for your review!

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@harheem harheem marked this pull request as ready for review September 8, 2023 05:21
jungnerd
jungnerd reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모델 문서 번역에 참여해주셔서 감사합니다! 좋은 번역이에요 😆
일부 문장에 새로운 제안을 드렸습니다. 검토 부탁드려요!

docs/source/ko/model_doc/llama.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/llama.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/llama.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/llama.md Outdated Show resolved Hide resolved
@jungnerd
Copy link
Contributor

jungnerd commented Sep 8, 2023

Hello, @stevhliu 👋
Should we translate the autodoc part in model_doc too?

@harheem
Copy link
Contributor Author

harheem commented Sep 8, 2023

모델 문서 번역에 참여해주셔서 감사합니다! 좋은 번역이에요 😆
일부 문장에 새로운 제안을 드렸습니다. 검토 부탁드려요!

리뷰 감사합니다! 코멘트 달아주신 것들이 전부 고민했던 부분이었는데, 좋은 표현 찾아주셔서 감사해요 🤩

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we translate the autodoc part in model_doc too?

The [[autodoc]] is part of the doc-builder syntax so you can leave it as it is. Thanks for the translation! 😄

@stevhliu stevhliu merged commit d536060 into huggingface:main Sep 8, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@harheem @parambharat
🌐 [i18n-KO] Translated llama.md to Korean (huggingface#26044)
9c1cd01 
* docs: ko-llama.md

* fix: chatgpt draft

* feat: manual edits

* fix: resolve suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungnerd jungnerd jungnerd left review comments

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harheem @jungnerd @HuggingFaceDocBuilderDev @stevhliu