Fix test_finetune_bert2bert
#25984
Merged
Fix test_finetune_bert2bert
#25984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 5, 2023
Comment on lines
+274
to
+283
| generation_inputs = inputs.copy() | ||
| # If the `decoder_input_ids` was created from `labels`, evict the former, so that the model can freely generate | ||
| # (otherwise, it would continue generating from the padded `decoder_input_ids`) | ||
| if ( | ||
| "labels" in inputs | ||
| and "decoder_input_ids" in inputs | ||
| and inputs["labels"].shape == inputs["decoder_input_ids"].shape | ||
| "labels" in generation_inputs | ||
| and "decoder_input_ids" in generation_inputs | ||
| and generation_inputs["labels"].shape == generation_inputs["decoder_input_ids"].shape | ||
| ): | ||
| inputs = {k: v for k, v in inputs.items() if k != "decoder_input_ids"} | ||
| generated_tokens = self.model.generate(**inputs, **gen_kwargs) | ||
| generation_inputs = {k: v for k, v in inputs.items() if k != "decoder_input_ids"} | ||
| generated_tokens = self.model.generate(**generation_inputs, **gen_kwargs) |
There was a problem hiding this comment.
The failed test started failing since d979cf6e (months ago 😅 ).
The modification of inputs here will be used in the next block related to training.
Since labels is in inputs, and we moved out decoder_input_ids, it tries to create decoder_input_ids from labels again in EncoderDecoder but failed as there is no padding token.
This PR just use generation_inputs (without decoder_input_ids) for generation but keep inputs untouched for training.
|
The documentation is not available anymore as the PR was closed or merged. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the CI error. See the comment in the change of this PR.