-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bf16 #25879
support bf16 #25879
Conversation
@mfuntowicz @amyeroberts Started a new PR for bf16 support here! |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
WDYT @ydshieh ? The |
+1 for this change ❤️ . |
Hi @etemadiamd I think your PR is on top of a commit on |
need a |
7c5a851
to
70990fc
Compare
70990fc
to
788ddb7
Compare
Hi @ydshieh, Thanks! Applied "make style and make quality". The "ci/circleci: check_code_quality" and "setup_and_quality" tests passed the CI checks. Now "run_tests" and "ci/circleci: examples_torch" tests failed with "Failed: Timeout >120.0s". Any idea to fix the failures? |
Thanks for the fix! For the timeout one, we can ignore it. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement!
Thanks again @etemadiamd ! |
* added bf16 support * added cuda availability check * applied make style, quality
What does this PR do?
Added bf16 support.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.