Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation to multilingual.mdx #21084

Merged

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Jan 11, 2023

Signed-off-by: Shogo Hida shogo.hida@gmail.com

What does this PR do?

Adds Japanese translation to multilingual.mdx

Fixes #18413

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@omarespejel @sgugger

Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 11, 2023

The documentation is not available anymore as the PR was closed or merged.

Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
@shogohida shogohida marked this pull request as ready for review January 11, 2023 09:38
@shogohida
Copy link
Contributor Author

I used the formal form to translate because Japanese is normally written in a formal way in docs.

I wrote this memo because one of the requirements was to use an informal tone. #18413 (comment)

@sgugger
Copy link
Collaborator

sgugger commented Jan 11, 2023

@ArthurZucker can you have a look here? Thanks!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of the structure! Thanks a lot for working on this 🚀

@ArthurZucker ArthurZucker merged commit 14154f7 into huggingface:main Jan 18, 2023
@shogohida shogohida deleted the add-ja-translation-to-multilingual.mdx branch January 18, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Japanese 🇯🇵
4 participants