Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vit deit fixes #11309

Merged
merged 4 commits into from
May 12, 2021
Merged

Vit deit fixes #11309

merged 4 commits into from
May 12, 2021

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

  • Some small documentation improvements of ViT + DeiT.
  • Adds a cats image to the fixtures/test_samples folder, which is used in the integration tests of both ViT and DeiT.
  • Adds a community notebook, illustrating how to fine-tune the Vision Transformer on CIFAR-10.

(there's something weird going on with the .gitignore within the test_samples folder , see files changed).

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

Not sure whats happening with gitignore maybe @LysandreJik knows :)

@patil-suraj
Copy link
Contributor

patil-suraj commented Apr 19, 2021

The notebook looks amazing!

Out of curiosity, have you tried using Trainer to fine-tune ViT?

@NielsRogge
Copy link
Contributor Author

Added a notebook that uses the Trainer. Includes a nice confusion matrix at the end :)

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LysandreJik LysandreJik merged commit fa84540 into huggingface:master May 12, 2021
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
* Improve docs of DeiT and ViT, add community notebook

* Add gitignore for test_samples

* Add notebook with Trainer

Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants