Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Async Functionality and Apply Code Refactoring #831 #849

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

hkjeon13
Copy link

@hkjeon13 hkjeon13 commented Mar 3, 2025

Summary

This pull request builds upon the asynchronous support introduced in the existing PR (#831) and incorporates additional refactoring to improve code maintainability and reduce duplication. The changes are aimed at enhancing integration with real-time services by enabling asynchronous operations alongside a more streamlined code structure.

Key Changes

  • Asynchronous Support

    • agents.py: Added AsyncMultiStepAgent, AsyncToolCallingAgent, and AsyncCodeAgent to enable asynchronous workflows.
    • models.py: Introduced AsyncModel, AsyncOpenAIServerModel, and AsyncAzureOpenAIServerModel.
  • Code Refactoring

    • Based on prior feedback(Async Agent Model #831), a separate commit has been dedicated to refactoring by introducing parent classes to manage both synchronous and asynchronous behaviors.
    • This refactoring effort resulted in a reduction of roughly 500 lines of code(compare to Async Agent Model #831)
    • Note: A more extensive refactoring was considered but postponed to avoid destabilizing the current implementation, as it would require major changes to existing functions.

@hkjeon13 hkjeon13 mentioned this pull request Mar 3, 2025
@maeste
Copy link
Contributor

maeste commented Mar 3, 2025

@hkjeon13 just for my understanding: so does this PR include what done in #831? If yes, can you close that one to avoid confusion? Or does this one depends on the other one merged?

@hkjeon13
Copy link
Author

hkjeon13 commented Mar 3, 2025

@hkjeon13 just for my understanding: so does this PR include what done in #831? If yes, can you close that one to avoid confusion? Or does this one depends on the other one merged?

Yes, it includes! I closed #831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants