fix agent name calculation for gradio app #812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue:
Name is optional and thus by default is
None
:smolagents/src/smolagents/agents.py
Line 214 in af03d17
Also if name is not event specified it is
None
as well:https://github.com/huggingface/smolagents/blob/main/src/smolagents/gradio_ui.py#L187
Hence the bugfix.
Maybe we can consider using this instead:
https://github.com/huggingface/smolagents/blob/main/src/smolagents/agents.py#L205