Add method support for tool decorator #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original tool decorator doesn't work on class methods because it unconditionally adds a self parameter treats method as if it were a plain function. That does not play nicely with Python’s bound-method behavior. This inspects the signature to prevent double-binding of self.
sysradium
reviewed
Feb 13, 2025
src/smolagents/tools.py
Outdated
| new_signature = original_signature.replace(parameters=new_parameters) | ||
| simple_tool.forward.__signature__ = new_signature | ||
|
|
||
| @functools.wraps(tool_function) |
There was a problem hiding this comment.
Aren't you reinventing inspect.ismethod and inspect.isfunction? First would correctly detect classmethod and just a method, the second will capture staticmethod and a regular function.
There was a problem hiding this comment.
Didn’t know about that one, thanks. Will confirm with tests today
sysradium
reviewed
Feb 13, 2025
Co-authored-by: Alex <sysradium@users.noreply.github.com>
|
Will do |
|
@albertvillanova @sysradium I added tests and documentation. Can you run the workflow for me? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…orators Merge main with test fixes
|
@albertvillanova Do you mind triggering the tests one more time? |
|
Any update on this? |
|
Unfortunately I don't have rights to run the workflow : / |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #574 and allows the tool decorator to work with class methods.
The original tool decorator doesn't work on class methods because it unconditionally adds a self parameter and treats methods as if it were a plain function. That does not play nicely with Python’s bound-method behavior. This inspects the signature to prevent double-binding of self.