Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Deep Research #317
Open Deep Research #317
Changes from all commits
394fe57
2adb556
17a793c
02a5bb5
4bd9e3c
850b4c3
7f3ce93
d8c481d
9699e2e
6a32465
8309740
31e0a48
a803b27
74ff788
28bb072
584fd6c
376a074
f2c5bec
078c4d9
08efff7
7cf4234
2650bf0
2af67f1
e70d817
dd11a3c
9be8854
3a0f8ce
74594d7
a15dfd1
e4968e9
993778a
4a87ecf
d9f2e5e
bd8d439
2068edf
f7dfcd4
bc2c63d
5d02247
38153a8
bfefdb1
36f0f39
9c2af92
87cd2fb
fa41ea2
f9ec253
a9d1769
c41a50a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you reverted my fix to FileNotFoundError...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the datasets library loads by default the viewer auto-generated Parquet version of the dataset (https://huggingface.co/datasets/gaia-benchmark/GAIA/tree/refs%2Fconvert%2Fparquet) and in this version:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before, you manually downloaded the data files to:
With the fix, the data files are now in:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Let's note for a later PR to integrate this improved file management that you propose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertvillanova actually I'd prefer to keep local files because I've done a manual screenshot of many documents( thus there is a check, if image path exists in png version it will be preferred to the base extension) (I could have done it automatically but wanted to spare time). I think this manually edited folder can be shared later on to make the code fully reproducible!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
final_result
is never used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No indeed! Since it's already in the last step of the agent's memory used in prepare_response I didn't include it. But maybe it would increase results to explicitly mention the response, good point! I'll try adding it.